[PATCH] D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test).

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin added inline comments.


================
Comment at: llvm/lib/CodeGen/StackSlotColoring.cpp:123
+          LiveRangeUpdater Updater(&JoinedLR);
+          auto *VNI = JoinedLR.getValNumInfo(0); // Don't care about valno.
+          for (auto &S : LI->segments)
----------------
arsenm wrote:
> vpykhtin wrote:
> > arsenm wrote:
> > > Don't understand why this is the case? Don't these need to be renumbered?
> > Joined interval isn't used for anything else than range overlapping test, I don't need value numbers.
> You might not need it, but will it fail the verifier?
It never reaches verifier I believe, it lives locally and dies after the overlapping test is done. It's not a fully valid object I agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146057/new/

https://reviews.llvm.org/D146057