[PATCH] D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test).

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/StackSlotColoring.cpp:98
+      LiveRange *FirstLR = nullptr; // First liverange (used to avoid copy when
+                                    // there is a sigle liverange per color).
+      LiveRange JoinedLR; // Joined liverange used when NumLRAssigned > 1.
----------------
Typo sigle


================
Comment at: llvm/lib/CodeGen/StackSlotColoring.cpp:123
+          LiveRangeUpdater Updater(&JoinedLR);
+          auto *VNI = JoinedLR.getValNumInfo(0); // Don't care about valno.
+          for (auto &S : LI->segments)
----------------
Don't understand why this is the case? Don't these need to be renumbered?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146057/new/

https://reviews.llvm.org/D146057