[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 08:57:29 PDT 2023


craig.topper added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:110
 
+extern void RISCVMarchHelp();
+
----------------
Can we declare this in RISCVISAInfo.h and include that here?


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:143
 
+void RISCVMarchHelp() {
+  auto Cmp = [](const RISCVSupportedExtension &a,
----------------
This function is not in the llvm namespace or a namespace nested under it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146054/new/

https://reviews.llvm.org/D146054



More information about the llvm-commits mailing list