[PATCH] D145209: [DAE] Don't DAE if we musttail call a "live" (non-DAE-able) function

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/test/Transforms/DeadArgElim/2010-04-30-DbgInfo.ll:111
 !29 = !{}
 !30 = !{i32 1, !"Debug Info Version", i32 3}
----------------
nikic wrote:
> Why the changes to this file? I don't see any musttail usage.
Misunderstanding on my part.


================
Comment at: llvm/test/Transforms/DeadArgElim/musttail-indirect.ll:1
+; RUN: opt -passes=deadargelim,verify -S < %s 2>&1 | FileCheck %s
+define internal i32 @test_caller(ptr %fptr, i32 %a, i32 %b) {
----------------
nikic wrote:
> mtrofin wrote:
> > nikic wrote:
> > > `verify` is unnecessary, as is `2>&1`, as is the CHECK-NOT. Verification failure causes a crash and will fail the test regardless of output.
> > > 
> > > Please also update update_test_checks.py.
> > done, sending a separate patch w the change in 2010-04-30-DbgInfo.ll, seems unrelated.
> This still has an unnecessary `verify` and doesn't use update_test_checks.
Ah, I misunderstood - I thought you meant "run `update_test_checks` on the other tests" - to see if they need a refresh due to this change (I assumed).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145209/new/

https://reviews.llvm.org/D145209