[PATCH] D145871: TableGen: Introduce `!range` operator for half-opened interval

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 08:29:12 PDT 2023


chapuni added a comment.

Thanks for your comment.

`!range(m, n)` and `!range(n)` come from Python.
`!range(list)` is just a syntax sugar.

I will accept even if a minimal functionality `(m, n)` would be landed. Do you think I should drop other syntax sugars?

> Add a couple of other reviewers so we can get a second opinion.

I will happy if you could nominate anyone, since you ask a second opinion.

> Add some simpler initial tests to range-op.td, such as the examples you gave in the summary.

I didn't think I could add simpler examples to the test. I will do if it would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145871/new/

https://reviews.llvm.org/D145871



More information about the llvm-commits mailing list