[PATCH] D146031: [AMDGPU] Add MMOs for GFX11 Streamout Instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 08:01:01 PDT 2023


foad added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:678
      Buffer Fat Pointer (experimental) 7               *TODO*
+     Streamout Registers               8               *TODO*      GS_REGS
      ================================= =============== =========== ================ ======= ============================
----------------
arsenm wrote:
> foad wrote:
> > My gut feeling is that this should be an internal implementation detail of the compiler, should never be exposed to the user, so should not be documented here.
> > 
> > Adding @nhaehnle.
> I do think we need to document any address space numbers used for any purpose. We should also probably reserve a range of address spaces for external software uses 
I was thinking this would be completely inaccessible from IR and only introduced during instruction selection. Do you agree? Do you still think it needs to be documented here? Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146031/new/

https://reviews.llvm.org/D146031



More information about the llvm-commits mailing list