[PATCH] D138992: [DebugInfo][SROA] Correct debug info for global variables spanning multiple fragments in case of SROA

Alok Kumar Sharma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 06:03:57 PDT 2023


alok marked an inline comment as done.
alok added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:451
+      // emit a fragment expression.
+    } else if (FragmentSizeInBits < VarSize) {
+      if (CurVarOffsetInBits > FragmentOffsetInBits)
----------------
aprantl wrote:
> could we replace this `else` with a `continue`/`return` inside the previous block?
Thanks, I have incorporated this comment in latest revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138992/new/

https://reviews.llvm.org/D138992



More information about the llvm-commits mailing list