[PATCH] D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Looks reasonable to me, but I don't feel entirely confident about what this does in the common MC layer changes.



================
Comment at: llvm/test/MC/COFF/alias.s:27
 // CHECK:        0x8 IMAGE_REL_I386_DIR32 global_aliased_to_local
-// CHECK:        0xC IMAGE_REL_I386_DIR32 external2
+// CHECK:        0xC IMAGE_REL_I386_DIR32 weak_aliased_to_external
 // CHECK:      ]
----------------
This looks curious - why does this change here?


================
Comment at: llvm/test/MC/COFF/weak-anti-dep.s:23
+// CHECK-NEXT:      Linked: b (8)
+// CHECK-NEXT:      Search: 0x4
+// CHECK-NEXT:    }
----------------
I guess it'd be good to teach `llvm-readobj` about this new mode too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145208/new/

https://reviews.llvm.org/D145208