[PATCH] D140400: [clang][RISCV][NFC] Combine RV32/RV64 ABI tests into single files

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.
Herald added a subscriber: jobnoorman.


================
Comment at: clang/test/CodeGen/RISCV/riscv32-abi.c:890
+// ILP32-ILP32F-ILP32D:  entry:
+//
+void f_int64_double_s_arg(struct int64_double_s a) {}
----------------
asb wrote:
> MaskRay wrote:
> > These `^//$` lines immediately before the code should be removed.
> It would be nice to do so, but that's what the tool currently outputs. Given the back and forth and iterations needed to have `--function-signature` include the return type, I've already invested quite a bit of time into `update_cc_test_checks.py` and it's hard to justify much more for a cosmetic issue.
> 
> Given I think this change is still overall positive for maintainability despite the fact the output could be cleaner, would you be happy for me to proceed with this and to file an issue for further improvements?
Hi @MaskRay - there are a few patches lined up depending on this one so I just wanted to check again if you're happy with the path forwards proposed above (i.e. to land as-is and to leave any further iteration on producing nicer update_cc_test_checks.py output for future work)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140400/new/

https://reviews.llvm.org/D140400