[PATCH] D146031: [AMDGPU] Add MMOs for GFX11 Streamout Instructions

[Jay Foad via Phabricator via llvm-commits]

foad added subscribers: nhaehnle, Pierre-vh.
foad added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:678
      Buffer Fat Pointer (experimental) 7               *TODO*
+     Streamout Registers               8               *TODO*      GS_REGS
      ================================= =============== =========== ================ ======= ============================
----------------
My gut feeling is that this should be an internal implementation detail of the compiler, should never be exposed to the user, so should not be documented here.

Adding @nhaehnle.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:388
 
+    STREAMOUT_REGISTER = 8, ///< Address space for GS NGG Streamout registers.
+
----------------
Maybe add a comment here saying "the following address spaces are internal-only and can be freely renumbered"? E.g. @Pierre-vh plans to add a new user-visible address space 8, but I think it should be fine to do that by renumbering STREAMOUT_REGISTER to 9 to make room.

I am assuming we will end up with more internal-only address spaces similar to this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146031/new/

https://reviews.llvm.org/D146031