[PATCH] D145990: [AMDGPU] Update mul.ll with auto-generated checks

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks good with nits.



================
Comment at: llvm/test/CodeGen/AMDGPU/mul.ll:4
+; RUN:  llc -amdgpu-scalarize-global-loads=false  -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefixes=VI %s
+; RUN:  llc -amdgpu-scalarize-global-loads=false  -march=amdgcn -mcpu=gfx900 -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9PLUS %s
+; RUN:  llc -amdgpu-scalarize-global-loads=false  -march=amdgcn -mcpu=gfx1010 -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX10PLUS %s
----------------
If the checks are not shared between different RUN lines then there is no reason to call them "GFX*PLUS". Just call them GFX9 and GFX10.


================
Comment at: llvm/test/CodeGen/AMDGPU/mul.ll:72-73
 
-; This 64-bit multiply should just use MUL_HI and MUL_LO, since the top
-; 32-bits of both arguments are sign bits.
-; FUNC-LABEL: {{^}}mul64_sext_c:
----------------
Keep this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145990/new/

https://reviews.llvm.org/D145990