[PATCH] D146014: [bazel][libc] Add errno target to function_deps of tests.

[Siva Chandra via Phabricator via llvm-commits]

sivachandra created this revision.
sivachandra added a reviewer: akuegel.
Herald added subscribers: ecnelises, tschuett.
Herald added a project: All.
sivachandra requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Existing listings in normal deps have been removed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146014

Files:
  utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl
  utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
  utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel
@@ -54,7 +54,6 @@
     ],
     deps = [
         "//libc:__support_fputil_fp_bits",
-        "//libc:errno",
     ],
 )
 
@@ -80,7 +79,6 @@
     deps = [
         "//libc:__support_cpp_limits",
         "//libc:__support_cpp_type_traits",
-        "//libc:errno",
         "//libc/test/UnitTest:LibcUnitTest",
     ],
 )
@@ -129,7 +127,6 @@
     ],
     deps = [
         "//libc:__support_fputil_fp_bits",
-        "//libc:errno",
         "//libc/utils/testutils:libc_test_utils",
     ],
 )
@@ -142,7 +139,6 @@
     ],
     deps = [
         "//libc:__support_fputil_fp_bits",
-        "//libc:errno",
         "//libc/utils/testutils:libc_test_utils",
     ],
 )
@@ -156,6 +152,5 @@
     deps = [
         "//libc:__support_fputil_fp_bits",
         "//libc:__support_uint128",
-        "//libc:errno",
     ],
 )
Index: utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
+++ utils/bazel/llvm-project-overlay/libc/test/src/math/libc_math_test_rules.bzl
@@ -33,7 +33,6 @@
             "//libc:__support_fputil_manipulation_functions",
             "//libc:__support_fputil_nearest_integer_operations",
             "//libc:__support_uint128",
-            "//libc:errno",
             "//libc/test/UnitTest:fp_test_helpers",
         ] + deps,
         **kwargs
Index: utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl
===================================================================
--- utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl
+++ utils/bazel/llvm-project-overlay/libc/test/libc_test_rules.bzl
@@ -24,10 +24,11 @@
       deps: The list of other libraries to be linked in to the test target.
       **kwargs: Attributes relevant for a cc_test. For example, name, srcs.
     """
+    all_function_deps = libc_function_deps + ["//libc:errno"]
     native.cc_test(
         name = name,
         srcs = srcs,
-        deps = [d + INTERNAL_SUFFIX for d in libc_function_deps] + [
+        deps = [d + INTERNAL_SUFFIX for d in all_function_deps] + [
             "//libc:libc_root",
             "//libc/test/UnitTest:LibcUnitTest",
         ] + deps,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146014.504964.patch
Type: text/x-patch
Size: 2545 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230314/9cc3cb22/attachment.bin>