[PATCH] D146012: [TableGen][RISCV][Hexagon][LoongArch] Add a list of Predicates to HwMode.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 23:58:12 PDT 2023


craig.topper created this revision.
craig.topper added reviewers: kparzysz, RKSimon, asb.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

Use the predicate condition instead of checkFeatures in *GenDAGISel.inc.

This makes the code similar to isel pattern predicates.

checkFeatures is still used by code created by SubtargetEmitter so
we can't remove the string. So backends need to be careful to keep
the string and predicates in sync, but I don't that's a big issue.

I haven't measured it, but this should be a compile time improvement
for isel since we don't have to do any of the string processing that's
inside checkFeatures.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146012

Files:
  llvm/include/llvm/Target/Target.td
  llvm/lib/Target/Hexagon/Hexagon.td
  llvm/lib/Target/LoongArch/LoongArch.td
  llvm/lib/Target/RISCV/RISCVFeatures.td
  llvm/test/TableGen/HwModeEncodeDecode.td
  llvm/test/TableGen/HwModeSelect.td
  llvm/utils/TableGen/CodeGenDAGPatterns.cpp
  llvm/utils/TableGen/CodeGenHwModes.cpp
  llvm/utils/TableGen/CodeGenHwModes.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146012.504958.patch
Type: text/x-patch
Size: 6488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230314/008de415/attachment.bin>


More information about the llvm-commits mailing list