[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

[Yevgeny Rouban via Phabricator via llvm-commits]

yrouban added a comment.

Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix.



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057
+  struct InstructionCount {
+    unsigned Count;
+  };
----------------
may be rename to //Value//?


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:2208
   // to ensure that other callbacks are not included in the timings.
   TimeProfilingPasses.registerCallbacks(PIC);
+
----------------
I think the time profiling pass has to be the last one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146003/new/

https://reviews.llvm.org/D146003