[PATCH] D145893: [X86][MC]Fix wrong action for encode movdir64b
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 13 21:24:53 PDT 2023
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:398
+ if (getMemIndexReg() &&
+ !X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemIndexReg()))
+ return false;
----------------
XinWang10 wrote:
> craig.topper wrote:
> > Do you need to include X86::EIZ?
> I search it and it is used in decoding? seems EIZ can not be used in encode, I try it with gas 'movdir64b 291(%esi, %eiz, 4), %ebx', and report 'Error: bad register name `%eiz''
gas requires `.allow_index_reg` directive to enable riz/eiz parsing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145893/new/
https://reviews.llvm.org/D145893
More information about the llvm-commits
mailing list