[PATCH] D145934: [RISCV] Precommit test to show wrong way to pass scalable FP vector on stack

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/calling-conv-vector-on-stack.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -mtriple=riscv64 -mattr=+v -verify-machineinstrs -treat-scalable-fixed-error-as-warning < %s 2>&1 | FileCheck %s
----------------
kito-cheng wrote:
> craig.topper wrote:
> > This wasn't fully generated by the script. You have a custom line for the warning. I think the script would delete that? I'd remove this comment.
> You mean the `; CHECK: warning: Invalid size request on a scalable vector`? the file other than the check is generated by `update_llc_test_checks.py`, and it will preserved :)
I meant the comment about being generated by the script so that people won't naively run the script. But if the script doesn't delete the warning check then its fine. I just the script was pretty aggressive about deleting things it doesn't know about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145934/new/

https://reviews.llvm.org/D145934