[PATCH] D145999: [RISCV] Reserve X18 by default for Android

Sami Tolvanen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 16:49:04 PDT 2023


samitolvanen accepted this revision.
samitolvanen added a comment.

LGTM. Folding D145979 <https://reviews.llvm.org/D145979> into this one might also make sense.



================
Comment at: clang/test/Driver/riscv-fixed-x-register.c:343
+
+// Check that x18 is reserved on Android by default
+// RUN: %clang --target=riscv64-linux-android -### %s 2> %t
----------------
This seems redundant. Isn't the LLVM codegen test sufficient here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145999/new/

https://reviews.llvm.org/D145999



More information about the llvm-commits mailing list