[PATCH] D145893: [X86][MC]Fix wrong action for encode movdir64b

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:395
+    if (getMemBaseReg() &&
+        !X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemBaseReg()))
+      return false;
----------------
Do you need to include X86::EIP?


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:398
+    if (getMemIndexReg() &&
+        !X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemIndexReg()))
+      return false;
----------------
Do you need to include X86::EIZ?


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:406
+    if (getMemBaseReg() &&
+        !X86MCRegisterClasses[X86::GR64RegClassID].contains(getMemBaseReg()))
+      return false;
----------------
Do you need to include X86::RIP?


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:409
+    if (getMemIndexReg() &&
+        !X86MCRegisterClasses[X86::GR64RegClassID].contains(getMemIndexReg()))
+      return false;
----------------
Do you need to include X86::RIZ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145893/new/

https://reviews.llvm.org/D145893