[PATCH] D145949: [RISCV] Consistently error for arch strings with trailing _

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 16:02:02 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:630
+  if (Arch.back() == '_')
+    return createStringError(errc::invalid_argument,
+                             "invalid format - trailing underscore");
----------------
Should be use the same "extension name missing after separator '_'" used later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145949/new/

https://reviews.llvm.org/D145949



More information about the llvm-commits mailing list