[PATCH] D145938: [RISCV] Pass vector argument by stack correctly.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:12798
   // needed.
-  if (ValVT.isFloatingPoint()) {
+  if (ValVT.isFloatingPoint() && !ValVT.isScalableVector()) {
     LocVT = ValVT;
----------------
I wonder if this should be `LocInfo == CCValAssign::BCvt` or `LocInfo != CCValAssign::Indirect`? Seems like an assumption is being made about the LocInfo here more than the type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145938/new/

https://reviews.llvm.org/D145938