[PATCH] D145969: [GVNHoist] add cast to unbreak windows build

Mon Mar 13 11:50:38 PDT 2023

kuhar added a comment.

In D145969#4190390 <https://reviews.llvm.org/D145969#4190390>, @nickdesaulniers wrote:

> In D145969#4190388 <https://reviews.llvm.org/D145969#4190388>, @kuhar wrote:
>
>> I'd consider defining a new `operator==` overload to handle cases like this instead.
>
> On which class? `Use` or `Instruction`?

I'm not 100% sure what existing `operator==` definitions there are, but I'd think we should be able to handle any two T* and U* that are derived from Value, regardless of their constness. This only makes sense if one is the base of the other. I think this could even be a free function.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145969/new/

https://reviews.llvm.org/D145969