[PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 11:48:28 PDT 2023

Previous message: [PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP
Next message: [PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

RKSimon added a comment.

Patch itself LGTM but the summary needs a cleanup - the defm section is irrelevant (and confusing) - just explain that ATOMIC_LOGIC_OP_RM shouldn't be using the *i8 instruction encodings


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145930/new/

https://reviews.llvm.org/D145930

Previous message: [PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP
Next message: [PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list