[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

[Erich Keane via Phabricator via llvm-commits]

erichkeane added a comment.

First, we've been dealing with the 16.0 release process/regressions, which unfortunately got us pretty far behind on reviews.  Sorry about that!

I have only 1 concern here, otherwise, this LGTM.  I'll leave it to Aaron to make the final 'value judgement' of if we want to keep this, so I'll leave it to him to Approve.



================
Comment at: clang/lib/AST/DeclBase.cpp:1056
+  else if (const auto *D = dyn_cast<TypedefNameDecl>(this))
+    Ty = D->getUnderlyingType();
+  else
----------------
probably want to canonicalize here (and above).  Else typedefs-to-typedefs/etc might getcha.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128440/new/

https://reviews.llvm.org/D128440