[PATCH] D145511: [Assignment Tracking] Downgrade dbg.assigns to dbg.values in mem2reg

[J. Ryan Stinnett via Phabricator via llvm-commits]

jryans accepted this revision.
jryans added a comment.
This revision is now accepted and ready to land.

Approach looks good to me, seems fine to land once you've addressed the comments below. 😄



================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:337
+  /// A set of dbg.assigns to delete because they've been demoted to
+  /// dbg.values. Call cleanUpDbgAssings to delete them.
+  SmallSet<DbgAssignIntrinsic *, 8> DbgAssignsToDelete;
----------------



================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:384
+  /// Delete dbg.assigns that have been demoted to dbg.values.
+  void cleanUpDbgAssings() {
+    for (auto *DAI : DbgAssignsToDelete)
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145511/new/

https://reviews.llvm.org/D145511