[PATCH] D144008: [DebugMetadata][DwarfDebug] Support function-local static variables in lexical block scopes (7/7)

Mon Mar 13 05:40:00 PDT 2023

krisb added a comment.

@jmmartinez

In D144008#4184543 <https://reviews.llvm.org/D144008#4184543>, @jmmartinez wrote:

> I've just finished reading and playing with the whole set of patches. Beside some minor nitpicks I've already posted everything else looks good to me.
>
> I also tried compiling LLVM with the patches to see if there was any difference in size in clang's binary (w/debug info and static linking): 1454920 Kb before the patch vs 1454684 Kb after. I've got simiar results when trying with split bash.
>
> I tested the code on some simple examples and it worked as expected.

Thank you so much for your efforts! I really appreciate your help with reviewing this patchset.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144008/new/

https://reviews.llvm.org/D144008