[PATCH] D144652: [Assignment Tracking] getIntrinsicInstrCost: set dbg.assign cost to zero

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/X86/free-intrinsics.ll:11
 ; CHECK-SIZE-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: call void @llvm.sideeffect()
-; CHECK-SIZE-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: call void @llvm.dbg.declare(metadata ptr undef, metadata !6, metadata !DIExpression()), !dbg !8
-; CHECK-SIZE-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: call void @llvm.dbg.label(metadata !9), !dbg !8
+; CHECK-SIZE-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: call void @llvm.dbg.assign(metadata ptr undef, metadata !6, metadata !DIExpression(), metadata !8, metadata ptr undef, metadata !DIExpression()), !dbg !9
+; CHECK-SIZE-NEXT:  Cost Model: Found an estimated cost of 0 for instruction: call void @llvm.dbg.declare(metadata ptr undef, metadata !6, metadata !DIExpression()), !dbg !9
----------------
jmorse wrote:
> Example of the cost being 1 for a dbg.assign, which would be wrong?
Aha yes, must have introduced this mistake while fiddling with D145573. Are you happy for me to just fix this before landing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144652/new/

https://reviews.llvm.org/D144652