[PATCH] D13595: [SCEV][LV] Add SCEV Predicates and use them to re-implement stride versioning

[Michael Marjieh via Phabricator via llvm-commits]

mmarjieh added inline comments.
Herald added subscribers: pcwang-thead, vkmr, rogfer01, javed.absar.
Herald added a project: All.


================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:154-157
+    /// \brief Generates a code sequence that evaluates this predicate.
+    /// The inserted instructions will be at position \p Loc.
+    /// The result will be of type i1 and will have a value of 0 when the
+    /// predicate is false and 1 otherwise.
----------------
Is the comment wrong? I see that in the implementation you do a invert of the operation.

I am talking about this:
The result will be of type i1 and will have a value of 0 when the
predicate is false and 1 otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D13595/new/

https://reviews.llvm.org/D13595