[PATCH] D145893: [X86][MC]Fix wrong action for encode movdir64b

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 12 23:39:22 PDT 2023


XinWang10 added a comment.

In D145893#4188004 <https://reviews.llvm.org/D145893#4188004>, @skan wrote:

>> Now llvm-mc can encode the asm 'movdir64b (%edx), rcx' but the result is the same as
>> 'movdir64b (%edx), ecx', which offend users' intention, while gcc will object this
>> action and give a warning.
>
> I am confused about this statement.
>
> 1. What does the "Now" mean here? Before this patch or after this patch?
> 2. I can only see memory operand change in this patch, why it affects the register operand?

For 1, Now means before, after this patch, we will report errors like gcc.
For 2, this instruction require the source reg operand consistent with mem base reg and index reg,
I change the mem operand to match their source register operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145893/new/

https://reviews.llvm.org/D145893



More information about the llvm-commits mailing list