[PATCH] D145374: [FuncSpec] Consider constant struct arguments when specializing.

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:868-869
+    } else {
+      const ValueLatticeElement &LV = getValueState(V);
+      mergeInValue(getValueState(NewArg), NewArg, LV);
     }
----------------
This looks not the same with the original statements. For example, we won't do anything if V is the OldArg and ValueState doesn't contain the OldArg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145374/new/

https://reviews.llvm.org/D145374