[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Anastasia Stulova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 12 15:21:16 PDT 2023


Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks



================
Comment at: clang/lib/CodeGen/TargetInfo.h:383
+
+  /// Return an LLVM target extension type that corresponds to an OpenCL type,
+  /// if such a type is necessary.
----------------
The default behaviour doesn't return a target extension type so maybe it's better to change the comment to:


```
Return an LLVM type that corresponds to an OpenCL type
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141008/new/

https://reviews.llvm.org/D141008



More information about the llvm-commits mailing list