[PATCH] D145471: [RISCV] Set how many bytes load from or store to stack slot

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 12 09:57:58 PDT 2023


craig.topper added a comment.

In D145471#4187128 <https://reviews.llvm.org/D145471#4187128>, @StephenFan wrote:

> This patch caused a code size regression in our ci tests https://github.com/dtcxzyw/llvm-ci/issues/8. And part of the extra codes it generates is as follows:
> F26778812: WechatIMG3384.jpeg <https://reviews.llvm.org/F26778812>
>
> I think the root cause is this patch makes the original function
>
>   unsigned isLoadFromStackSlot(const MachineInstr &MI,
>                                  int &FrameIndex) const override;
>
> no longer be overridden.

I have restored the original signatures and mapped them to the new signatures the same way x86 does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145471/new/

https://reviews.llvm.org/D145471



More information about the llvm-commits mailing list