[PATCH] D145879: [RISCV][test] Expand test coverage of RISCVISAInfo
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 12 09:03:33 PDT 2023
asb created this revision.
asb added reviewers: kito-cheng, MaskRay, jrtc27, reames, craig.topper.
Herald added subscribers: luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, niosHD, sabuasal, simoncook, johnrusso, rbar, arichardson.
Herald added a project: All.
asb requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD.
Herald added a project: LLVM.
D144343 <https://reviews.llvm.org/D144343> added C++ unit tests for the newly added `RISCVISAInfo::parseArchStringNormalized`. This patch adds test coverage for `parseArchString` and the `toFeatureVector` member method.
Posting for review as it would be useful if someone can take a quick look to check they don't feel I've missed testing an important aspect of the current behaviour.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D145879
Files:
llvm/unittests/Support/RISCVISAInfoTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145879.504450.patch
Type: text/x-patch
Size: 16269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230312/8db209a5/attachment.bin>
More information about the llvm-commits
mailing list