[PATCH] D145863: [X86][NFC] Use uint64_t for passing the alignment

[Phoebe Wang via Phabricator via llvm-commits]

pengfei created this revision.
pengfei added a reviewer: RKSimon.
Herald added a subscriber: hiraditya.
Herald added a project: All.
pengfei requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This should be a typo in `emitConstantSizeRepmov`. Both its caller and
callee store the alignment in a 64-bit variables, no reason to truncate
it to 32-bit. It results in alignment turns into 0 when larger than
0x100000000.

I don't think an alignment 0x100000000 is reasonable and don't know where
it comes from. So I tends to not use the reproducer in #61348 as regression
test.

Fixes #61348


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145863

Files:
  llvm/lib/Target/X86/X86SelectionDAGInfo.cpp


Index: llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
===================================================================
--- llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
+++ llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
@@ -204,7 +204,7 @@
 static SDValue emitConstantSizeRepmov(
     SelectionDAG &DAG, const X86Subtarget &Subtarget, const SDLoc &dl,
     SDValue Chain, SDValue Dst, SDValue Src, uint64_t Size, EVT SizeVT,
-    unsigned Align, bool isVolatile, bool AlwaysInline,
+    uint64_t Align, bool isVolatile, bool AlwaysInline,
     MachinePointerInfo DstPtrInfo, MachinePointerInfo SrcPtrInfo) {
 
   /// TODO: Revisit next line: big copy with ERMSB on march >= haswell are very


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145863.504413.patch
Type: text/x-patch
Size: 686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230312/0d90eb9e/attachment.bin>