[PATCH] D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

[Igor Zhukov via Phabricator via llvm-commits]

fsb4000 added a comment.

Hi!

I'm going to revert this commit.

`git bisect` shows that after that commit libc++ tests started to fail.

  b00aaab730ae8bd7f8a44e1808e668e20c2c9282 is the first bad commit
  commit b00aaab730ae8bd7f8a44e1808e668e20c2c9282
  Author: Petr Hosek <phosek at google.com>
  Date:   Thu Mar 9 18:23:04 2023 +0000
  
      [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag
  
      These will be replaced by CMake's check_linker_flag once we update
      the minimum CMake version 3.20.
  
      Differential Revision: https://reviews.llvm.org/D145716
  
   cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake | 41 ++++++++++---------------
   1 file changed, 17 insertions(+), 24 deletions(-)

Look at the recent "Scheduled build": https://buildkite.com/llvm-project/libcxx-ci/builds/20490

I created https://reviews.llvm.org/D145858 and it looks the tests pass after revertion: https://buildkite.com/llvm-project/libcxx-ci/builds/20495


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145716/new/

https://reviews.llvm.org/D145716