[PATCH] D145703: [SPIR-V] Add Machine Value Type for SPIR-V builtins

[Michal Paszkowski via Phabricator via llvm-commits]

mpaszkowski added inline comments.


================
Comment at: llvm/lib/CodeGen/ValueTypes.cpp:592
       return MVT(MVT::aarch64svcount);
+    else if (TargetExtTy->getName().starts_with("spirv."))
+      return MVT(MVT::spirvbuiltin);
----------------
sdesmalen wrote:
> is it sufficient to only specify a single MVT for the different SPIRV types?
It is sufficient for our current use. We do not rely on IRTranslator to lower these types, but rather have a custom lowering mechanism in SPIRVCallLowering.cpp and SPIRVBuiltins.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145703/new/

https://reviews.llvm.org/D145703