[PATCH] D145805: [DWARFLinker][DWARFv5] Add support for DW_FORM_addrx*

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1374
+  case dwarf::DW_FORM_addrx4:
+    // FIXME: add support for DW_FORM_LLVM_addrx_offset
     return cloneAddressAttribute(Die, InputDIE, AttrSpec, AttrSize, Val, Unit,
----------------
I wouldn't stress about this - no debugger has support for it, it was a prototype for getting data and the version that was standardized is slightly different (takes offset as a uleb). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145805/new/

https://reviews.llvm.org/D145805