[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

[Aaron Puchert via Phabricator via llvm-commits]

aaronpuchert added a comment.
Herald added a subscriber: pcwang-thead.
Herald added a project: All.

Basically this should be Ok. We set the `LLVM_HOST_TRIPLE` to match the GCC triple on almost all platforms now.

But we'll need to patch `isGNUEnvironment` like D110900 <https://reviews.llvm.org/D110900> does and the previously mentioned `config.guess` changes.



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2091-2092
-                                             "armv7hl-redhat-linux-gnueabi",
-                                             "armv6hl-suse-linux-gnueabi",
-                                             "armv7hl-suse-linux-gnueabi"};
   static const char *const ARMebLibDirs[] = {"/lib"};
----------------
Not sure if we can remove them. We now use `gnueabihf` in the default triple, but I think the GCC installation is still at `-gnueabi`. Also we're using `armv6kz` instead of `armv6hl` for some reason that's beyond my understanding.


================
Comment at: llvm/lib/Support/Triple.cpp:989-991
-  // SUSE uses "gnueabi" to mean "gnueabihf"
-  if (Vendor == Triple::SUSE && Environment == llvm::Triple::GNUEABI)
-    Components[3] = "gnueabihf";
----------------
We have that included in out `LLVM_HOST_TRIPLE` now, so this should be fine. But this means we'll need to keep the translation to GCC triple alive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109727/new/

https://reviews.llvm.org/D109727