[PATCH] D123394: [CodeGen] Late cleanup of redundant address/immediate definitions.

Sat Mar 11 03:13:45 PST 2023

jonpa added a comment.

In D123394#4186531 <https://reviews.llvm.org/D123394#4186531>, @vpykhtin wrote:

>> Makes sense to me - I tried also earlier to store the kills in a map but I found (at least on SystemZ) that this backwards search was actually quicker than that, so I don't think it should be an issue in the normal case...
>
> Hello Jonas, just FYI I got case:
>
>   Total Execution Time: 670.4078 seconds (670.7149 wall clock)
>   
>      ---User Time---   --System Time--   --User+System--   ---Wall Time---  --- Name ---
>     289.2998 ( 43.7%)   0.1439 (  1.8%)  289.4437 ( 43.2%)  289.5775 ( 43.2%)  Structurize control flow
>     124.9852 ( 18.9%)   0.0000 (  0.0%)  124.9852 ( 18.6%)  125.0289 ( 18.6%)  Machine Late Instructions Cleanup Pass
>     45.2408 (  6.8%)   0.0000 (  0.0%)  45.2408 (  6.7%)  45.2740 (  6.8%)  SI Form memory clauses
>     38.0358 (  5.7%)   0.0240 (  0.3%)  38.0598 (  5.7%)  38.0767 (  5.7%)  Simple Register Coalescing
>
> Most of the time is spent in clearKillsForDef.

Hi Valery, thanks for the report! It would be nice if you posted your test case on github issues and assigned me (and/or yourself :)... I would think this could be fixed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123394/new/

https://reviews.llvm.org/D123394