[PATCH] D144407: [NVPTX] Sync generation of parameter names in a function signature with the function body.

Pavel Kopyl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 17:59:40 PST 2023


pavelkopyl added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/anonymous-fn-param.ll:11-13
+; CHECK:      .func (.param .b32 func_retval0) __unnamed_2(
+; CHECK-NEXT: .param .b32 __unnamed_2_param_0
+; CHECK:      ld.param.u32 {{%r[0-9]+}}, [__unnamed_2_param_0];
----------------
tra wrote:
> I'd move it down to the second function. When possible, checks should be placed close to the code that we're checking.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144407/new/

https://reviews.llvm.org/D144407



More information about the llvm-commits mailing list