[PATCH] D145827: [cmake] Quote args when generating /libpath option specifying runtime dir for link/lld-link

Matthew Voss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 14:13:27 PST 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG26fa96542d94: [cmake] Quote args when generating /libpath option specifying runtime dir for… (authored by ormris).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145827/new/

https://reviews.llvm.org/D145827

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -1102,7 +1102,7 @@
   endif()
   file(TO_CMAKE_PATH "${clang_compiler_rt_file}" clang_compiler_rt_file)
   get_filename_component(clang_runtime_dir "${clang_compiler_rt_file}" DIRECTORY)
-  append("/libpath:${clang_runtime_dir}"
+  append("/libpath:\"${clang_runtime_dir}\""
     CMAKE_EXE_LINKER_FLAGS
     CMAKE_MODULE_LINKER_FLAGS
     CMAKE_SHARED_LINKER_FLAGS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145827.504278.patch
Type: text/x-patch
Size: 581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230310/93c15c01/attachment.bin>


More information about the llvm-commits mailing list