[PATCH] D145626: [WebAssembly] Support debug info for TLS + global in PIC mode

Fri Mar 10 10:29:44 PST 2023

dschuff added a comment.

Ah right. With regular codegen tests we don't have this kind of problem because the assembly output is symbolic; also some tests that test disassembly use `objdump -dr` which prints relocation info next to instructions that need relocations. But I don't think dwarfdump will do that.
I agree that moving this test to lld doesn't seem great either.

We could test explicitly for relocation information using llvm-readobj (many MC tests do this). I guess for the static linking cases we could assert that there's a relocation against `__stack_pointer` and in the split dwarf case we could check that there are no relocations. Not sure whether that would be worth it though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145626/new/

https://reviews.llvm.org/D145626