[PATCH] D145732: [SLP][NFC]Initial merge of gather/buildvector code in the createBuildVector function.

Valeriy Dmitriev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 10:23:09 PST 2023


vdmitrie added a comment.

Looks good with a nit. I'm fine if it addressed in a separate patch since we have quite a few places in SLP vectorizer like here:
for (auto [I, V] : enumerate(VL)) {

To be less confusing they all better to be changed to either:
for (const auto &[I, V] : enumerate(VL)) {
or
for (auto &[I, V] : enumerate(VL)) {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145732/new/

https://reviews.llvm.org/D145732



More information about the llvm-commits mailing list