[PATCH] D144221: [amdgpu][nfc] Replace ad hoc LDS frame recalculation with absolute_symbol MD

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 10:14:42 PST 2023


JonChesterfield added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:826
 
+      // This struct is allocated at a predictable address that can be
+      // calculated now, recorded in metadata then used to lower references to
----------------
This is right but moderately annoying to extend for D144233 - would rather land this as is and then amend


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144221/new/

https://reviews.llvm.org/D144221



More information about the llvm-commits mailing list