[PATCH] D145677: [ConstraintElimination] Fix undefined behaviour in shl decomposition
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 10 10:06:16 PST 2023
fhahn added a comment.
In D145677#4185360 <https://reviews.llvm.org/D145677#4185360>, @vitalybuka wrote:
> In D145677#4184405 <https://reviews.llvm.org/D145677#4184405>, @fhahn wrote:
>
>> Thanks for the fix @vitalybuka ! I am surprised this wasn't covered by the added tests. Any idea why that is?
>
> I guess you need shift by [32; 63] to hit this case
Right, @zjaffal could you add a test case which shifts by an offset between [32; 63] ? Ideally one where ConstraintElimination can perform a simplification.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145677/new/
https://reviews.llvm.org/D145677
More information about the llvm-commits
mailing list