[PATCH] D145410: [Flang][OpenMP] Add support for logical or reduction in worksharing-loop

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LG.



================
Comment at: flang/test/Lower/OpenMP/wsloop-reduction-logical-or.f90:7
+!CHECK: ^bb0(%{{.*}}: !fir.logical<4>):
+!CHECK:  %false = arith.constant false
+!CHECK:  %[[false_fir:.*]] = fir.convert %false : (i1) -> !fir.logical<4>
----------------
Nit:capture this value in a variable.


================
Comment at: flang/test/Lower/OpenMP/wsloop-reduction-logical-or.f90:8
+!CHECK:  %false = arith.constant false
+!CHECK:  %[[false_fir:.*]] = fir.convert %false : (i1) -> !fir.logical<4>
+!CHECK:  omp.yield(%[[false_fir]]  : !fir.logical<4>)
----------------
Nit:Typically caps are used for Variables like `false_fir`. Same for `arg0_i1` and `arg1_i1` below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145410/new/

https://reviews.llvm.org/D145410