[PATCH] D144489: [VPlan] Replace InvariantCond field from VPWidenSelectRecipe.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:965
+  bool isInvariantCond() const {
+    return getOperand(0)->isDefinedOutsideVectorRegions();
+  }
----------------
Ayal wrote:
> nit: worth adding getCond() to VPWidenSelectRecipe? (Independent of this patch.)
> 
> nit: better place isInvariantCond() method below, after con/destructor?
> nit: worth adding getCond() to VPWidenSelectRecipe? (Independent of this patch.)

Done in 9be8d90e62a1

> nit: better place isInvariantCond() method below, after con/destructor?

Done in the committed version, thanks! 


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:968
 
 public:
   template <typename IterT>
----------------
Ayal wrote:
> nit: `public:` here is now redundant given that `class` became `struct`?
Done in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144489/new/

https://reviews.llvm.org/D144489