[PATCH] D145578: [AArch64] Cost-model vector splat LD1Rs to avoid unprofitable SLP vectorisation

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 05:52:12 PST 2023


SjoerdMeijer updated this revision to Diff 504113.
SjoerdMeijer added a comment.

I like it when I can delete things and achieve the same, so I have just done that. This was my understanding of your comments. Thanks for the suggestion and for looking into this.

So with this new revision, the SLP vectorisation tests won't be vectorised, which is what we want. 
For the cost-model test, there are 2 changes compared to the previous revision: there is of 21 and 42 for a shuffle of half types. Probably need looking into, and fixed in a companion patch with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145578/new/

https://reviews.llvm.org/D145578

Files:
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/AArch64/shuffle-load.ll
  llvm/test/Transforms/SLPVectorizer/AArch64/slp-fma-loss.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145578.504113.patch
Type: text/x-patch
Size: 25155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230310/4503c733/attachment.bin>


More information about the llvm-commits mailing list