[PATCH] D145614: [AARCH64] Enable STORE of v4i8 to help more vectorization opportunities

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 04:47:45 PST 2023


dmgreen added a comment.

Hello. This looks like a nice idea. We have done some work to make v4i8 better in the recent past. I hadn't realized that the slp vectorizer wasn't making use of that for stores.

>From what I can tell it looks like this is trying to use `setOperationAction(ISD::STORE, MVT::v4i8,  Custom)` as way to get TargetTrasformInfo::getStoreMinimumVF to allow starting vectorization at v8i4 stores. We already make the truncstore custom in `setTruncStoreAction(MVT::v4i16, MVT::v4i8, Custom)` further down the file. Can we use that in getStoreMinimumVF instead? Either have it use `isTruncStoreLegalOrCustom` as opposed to `isTruncStoreLegal`, or override it in an AArch64 version of the method?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145614/new/

https://reviews.llvm.org/D145614



More information about the llvm-commits mailing list