[PATCH] D144638: [lit] Detect Inconsistent File Access Times

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Related to my inline comment, your changes will result in some tests being disabled on Windows that weren't before (at least one of the tests pass for me even on my machine where atime is disabled). I think we need to understand why these tests pass on Windows before losing test coverage by disabling them.



================
Comment at: llvm/utils/lit/lit/llvm/config.py:172
+        # Windows: the last access time is disabled by default in the OS, and
+        # the check below is written in terms of unix utilities (touch, ls),
+        # which will not work on this platform.
----------------
As mentioned, I don't think this is a fair statement: many tests use `touch` or `ls`, and work fine on Windows. That being said, the top Google result for how to detect if access time is enabled on Windows yields the following command: `fsutil behavior query disablelastaccess`, which prints some information about its state that could be easily queried in python to give a more correct answer for Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144638/new/

https://reviews.llvm.org/D144638