[PATCH] D145762: Reduce inlining that had larger binary size impact

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini requested changes to this revision.
mehdi_amini added a comment.
This revision now requires changes to proceed.

In general I am quite concerned about messing with the optimizer this way, this should be extremely exceptional. This'll be ad-hoc, forces a performance tradeoff specific to a given use case, and couple the "heuristic" to the exact compiler you're using (what does it do on Windows? On Mac?). 
Have you tried building your project with `-Os`? `-Oz`? PGO? FullLTO?



================
Comment at: mlir/include/mlir/Support/TypeID.h:192
 
-  static TypeID resolveTypeID() {
+  LLVM_ATTRIBUTE_NOINLINE static TypeID resolveTypeID() {
     static_assert(is_fully_resolved<T>::value,
----------------
Isn't this a potentially hot routine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145762/new/

https://reviews.llvm.org/D145762